Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Improving error message #154

Closed
wants to merge 2 commits into from
Closed

Conversation

Riyadh1734
Copy link
Contributor

Improving a little bit changes to the 404 error page. I think this is most important to users.

@jeffikus
Copy link

Hi @Riyadh1734 - I don't think this is good idea to add into the theme, in particular using mention of the pandemic quarantine. I understand the intention of your submission, but this has the potential to bring back some painful memories/experiences for some folks, and I think the "This page could not be found." is sufficient.

@@ -9,7 +9,7 @@ <h2 class="has-text-align-center" style="font-size:clamp(4rem, 40vw, 20rem);font
<!-- wp:paragraph {"align":"center"} -->
<p class="has-text-align-center">This page could not be found.</p>
<!-- /wp:paragraph -->

<div class="msg">Maybe this page moved? Got deleted? Is hiding out in quarantine? Never existed in the first place?<p>Let's go <a href="#">home</a> and try from there.</p></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="msg">Maybe this page moved? Got deleted? Is hiding out in quarantine? Never existed in the first place?<p>Let's go <a href="#">home</a> and try from there.</p></div>
<div class="msg">
<p>Maybe this page moved, got deleted or never existed in the first place?</p>
<p>Let's go <a href="/">home</a> and try from there.</p>
</div>

I think this should be done more like this - with 2 paragraphs and a real link to home.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be changed anytime. Thank you for your suggestion.

@jeffikus
Copy link

I think, if anything it could be more aligned with prior default themes;

There is no need imo for a home link as headers typically have that.

@kjellr
Copy link
Collaborator

kjellr commented Oct 25, 2021

Thanks for the discussion everyone. I agree with @jeffikus on this one. If you'd like to update the default message to be:

It looks like nothing was found at this location. Maybe try a search?

That works for me. 👍

As it is currently, the markup in this PR is not valid block markup though. We'd want to just replace the string on L10.

@Riyadh1734
Copy link
Contributor Author

There is no problem that the home link can be omitted. But there are two lines very important for new users.

@Riyadh1734
Copy link
Contributor Author

Hi @jeffikus I agree with you about mentioning pandemic quotes but another two lines are very important for new users & it seems too different but it's helpful.
And also we use "This page could not be found" as sufficient for all. but this time I think "Maybe this page moved? Got deleted? Never existed in the first place? Let's go home and try from there" this message helps new users.

@jeffikus
Copy link

@Riyadh1734 I hear what you are trying to achieve, my counter point would be then do we list all the possible reasons why a page could not be found? From my perspective that's what the search field is for, the only addition I would consider here is the second part of this line, the "Maybe try a search?" part.

@pattonwebz
Copy link
Member

Just chiming in here to say I am indifferent to the actual message used. My concerns were only to not mention quarantine and that the text is contained within the right (semantically) markup.

@Riyadh1734
Copy link
Contributor Author

@jeffikus lf this is good for all folks.then that's also ok for me. Go for it :)

@jffng
Copy link
Collaborator

jffng commented Nov 2, 2021

Closing since the message was changed in #182: 66c8ade

Thanks everyone for the improvement.

@jffng jffng closed this Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants